[PATCH] ctdb-locking: Back-off from logging every 10 seconds

Martin Schwenke martin at meltin.net
Fri Mar 6 04:55:42 MST 2015

On Thu, 5 Mar 2015 12:39:40 +0100, Volker Lendecke
<Volker.Lendecke at SerNet.DE> wrote:

> On Thu, Mar 05, 2015 at 10:29:27PM +1100, Martin Schwenke wrote:
> > >Attached find two small patches on top of your patch.
> > >
> > >Review&push if ok.
> > 
> > 
> > I don't think you want the 2nd patch. debug_locks is static.  The environment variable can't change so we cache the value in the static.  We do that in a few places. 
> Hmm. Ok. But is talloc off ctdb the right thing then? If the
> string goes away, "debug_locks" will have a bogus pointer.
> This won't happen probably, but it is still confusing. At
> least it confused me.

Good point.  I have the perfect way of making this much, much clearer.
Patch soon...  :-)

peace & happiness,

More information about the samba-technical mailing list