[PATCH] Add tests for pytalloc

Petr Viktorin pviktori at redhat.com
Fri Mar 6 04:50:07 MST 2015


On 03/05/2015 04:00 PM, Stefan (metze) Metzmacher wrote:
> Hi Petr,
>
> can you please split the wafsamba change into it's own commit.

Of course; attached.


> Am 05.03.2015 um 14:23 schrieb Petr Viktorin:
>> Hello,
>> I couldn't find any tests for talloc's Python bindings, so I wrote some.
>>
>> The tests are a bit biased towards comparisons. This is because I'd like
>> to switch that part to be Python3-compatible (richcmp), and I want to
>> make it clear to myself and others that the functionality is unchanged
>> under Python 2.
>> Also, as you'll find if you run the tests, the current comparisons
>> generate warnings.
>>
>> Review & merge would be appreciated.
>>
>>
>>
>> I've looked at how tests for Python bindings for the various standalone
>> libraries (ldb, tdb, ntdb, ) are run, and found that it's done
>> differently each time. As part of the Python 3 effort, I'd like to write
>> a helper to run Python tests (specifically, to run them under both
>> Python versions, if you choose to build support for them). Are there any
>> current efforts in this area, or thoughts about the ideal state, that I
>> should be aware of?
>>
>>
>


-- 
Petr Viktorin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-wafsamba-Add-install-argument-to-SAMBA_PYTHON.patch
Type: text/x-patch
Size: 1234 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150306/f7cb827b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-pytalloc-Add-tests.patch
Type: text/x-patch
Size: 9291 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150306/f7cb827b/attachment-0001.bin>


More information about the samba-technical mailing list