[PATCH] ctdb-locking: Back-off from logging every 10 seconds

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Mar 5 04:39:40 MST 2015


On Thu, Mar 05, 2015 at 10:29:27PM +1100, Martin Schwenke wrote:
> >Attached find two small patches on top of your patch.
> >
> >Review&push if ok.
> 
> 
> I don't think you want the 2nd patch. debug_locks is static.  The environment variable can't change so we cache the value in the static.  We do that in a few places. 

Hmm. Ok. But is talloc off ctdb the right thing then? If the
string goes away, "debug_locks" will have a bogus pointer.
This won't happen probably, but it is still confusing. At
least it confused me.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list