[PATCH] More coverity fixes

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Mar 4 06:59:51 MST 2015

On Wed, Mar 04, 2015 at 02:46:03PM +0100, David Disseldorp wrote:
> On Wed, 4 Mar 2015 12:20:24 +0100, Volker Lendecke wrote:
> > Thanks! New version attached.
> Thanks Volker. I've pushed everything to autobuild except:
> [PATCH 06/17] libads: ZERO_STRUCT->initializer
> I let the whitespace cleanup slip through, but I'd prefer not to see a
> heap of initialisation refactoring unless it's fixing something.

My reasoning behind this is: ZERO_STRUCT is a macro that calls memset,
which is a library function. The initializer is a language feature. So in
theory we give the compiler more or more easily accessible information
about our intention. This might lead to more efficient code or better
diagnostics. I don't have proof that this actually improves things,
but to me less lines of C are always good :-)


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list