[PATCHES v2] Reorganize code for wrapping gpfs library

Christof Schmitt cs at samba.org
Sun Mar 1 21:16:45 MST 2015

On Fri, Feb 27, 2015 at 05:20:24PM +0100, Ralph Böhme wrote:
> Hi!
> *phew* That review was fun, I guess producing this nice patch series
> was even more fun! ;)

Thank you for the review! Yes, that was some fun work to get everything
nicely separated now.

> I have one question:
> On Wed, Feb 25, 2015 at 04:49:41PM -0700, Christof Schmitt wrote:
> > Here is the updated patch series for reorganizing the gpfs library
> > wrapper code. The idea is to have a very thin wrapper for the gpfs
> > library to avoid hard link dependencies. The actual logic for the vfs
> > module is moved to vfs_gpfs.c
>     accaa0ce2507ecb2d7fe1427daee6b4ded10b851
>     gpfs: Remove search for libgpfs_gpl.so
>     Similar to the header files, libgpfs_gpl.so no longer exists.
>     The library is now always called libgpfs.so.
> Doesn't this break backward compatibility ?

This breaks backwards compatibility to very old levels of GPFS, and i
don't think that we need to maintain that. IMHO, Samba master should
work with any supported level of GPFS, and currently 3.4 and 3.5 are


According to
GPFS moved the code to libgpfs.so, and 3.2 went out of service
in 2011.

> Othen then that, all rb: me.

Thanks again. If there are no objections, i will push the code tomorrow.


More information about the samba-technical mailing list