[PATCH] lib: Fix rundown of open_socket_out()

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Jun 30 04:31:23 MDT 2015

On Tue, Jun 30, 2015 at 12:23:33PM +0200, Stefan (metze) Metzmacher wrote:
> Hi Volker,
> > Maybe another contributor to flaky builds.
> > 
> > Review&push appreciated!
> Reviewed-by: me
> Do we need this backported (together with your coverity fixes in
> lib/async_req/async_sock.c) as part of
> https://bugzilla.samba.org/show_bug.cgi?id=11316 ?
> If so please add the bug url before pushing.

This one is probably worthwhile backporting. I'm not sure about the
others. The abort() one made us abort and thus revealed another bug. How
many others are lurking in our code which cause no user-visible harm so
far but which will then abort()? Tough choice.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list