[PATCH] wafsamba: Remove code which is not used in most cases

Martin Schwenke martin at meltin.net
Mon Jun 29 21:33:33 MDT 2015


On Mon, 29 Jun 2015 16:18:48 +1000, Amitay Isaacs <amitay at gmail.com>
wrote:

> On Mon, Jun 29, 2015 at 2:35 PM, Thomas Nagy <tnagy at waf.io> wrote:
> 
> > These changes will result in Samba incremental taking a much longer time
> > to start: 2.5s -> 6s.
> >
> 
> Ah, I missed the use case for incremental build. :-)
> 
> 
> >  If the install build differs so much from the normal build, how about
> > having the dependency cache depend on the previously executed command
> > (build/install)?
> >
> 
> It's not the question of install build differing from normal build.
> Install build uses some of the target variables which are not cached and
> results in incorrectly linked (missing rpath) binaries.
> 
> 
> > Thomas
> >
> 
> How about the attached patch?  It just adds 'final_libs' to cached output
> variables.

Pushed to autobuild.

peace & happiness,
martin


More information about the samba-technical mailing list