[PATCH] Increase writetimeupdatedelay and sharedelay in Samba4.pm, remove winbind from Samba for 4.3
obnox at samba.org
Mon Jun 29 02:53:27 MDT 2015
On 2015-06-29 at 09:27 +0200, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> >> What this patch does is remove the *internal* winbind from
> >> the source4 directory. This was replaced by default with
> >> winbindd from source3 in Samba 4.2, and this patch is to
> >> remove it. Unlike other areas of duplication, this has no
> >> redeeming features in my view, so now we have fixed the
> >> classicupgrade issues (on which this patch builds), we can
> >> remove it.
> >> I'm running private autobuilds to confirm I got the
> >> knownfail changes correct, but in the meantime I want to
> >> ensure there is the opportunity for reasonable discussion
> >> here.
> > The attached two patches pass autobuild on the Catalyst Cloud
> > other than the usual knownfail on the notify tests. To do
> > that, I had to match the writetimeupdatedelay and sharedelay
> > parameters in Samba4.pm to match Samba3.pm. I'm not sure
> > what about the different winbind implementations changes the
> > timing in the ntvfs file server, but this seems a reasonable
> > change, if only for consistency.
> > Now I have that settled, could someone please review/push?
> This causes a lot of flakey tests, mainly because the
> server_maxtime is reached.
> We should try to remove some tests, source3/selftest/tests.py
> seems to call a lot of rpc. tests also against ad_dc, which
> should already be covered by source4/selftest/tests.py. Can you
> have a look at that?
> So in the meantime can someone please push the attached patch
> that changes the maximum runtime to 3 hours.
> But I also got this at least two times:
> [1373(7743)/1865 at 1h40m14s]
> smbtorture 4.3.0pre1-DEVELOPERBUILD
> Using seed 1435535709
> Starting 4 clients
> 4 clients started
> pid 11998: Testing deferred open requests.
> pid 11998: create[0,1]...
> pid 11999: open 3
> pid 11999: open 3 closed, status NT_STATUS_OK
> pid 11999: deferred test finished
> REASON: Exception: Exception: child 3 (pid 12000) failed: Timing
> incorrect 0.00 violation 1 sec == 0.10
This and some kcc tests seem to be the most
prominent flakey tests at the moment, which
started last to happen much more frequently
again since June 24/25.
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the samba-technical