[PATCH] Revert "lib: Fix deps for LIBCRYPTO" because arcfour need DATA_BLOB

Jeremy Allison jra at samba.org
Sun Jun 28 10:37:10 MDT 2015


On Sun, Jun 28, 2015 at 01:04:45AM +0200, Michael Adam wrote:
> On 2015-06-26 at 06:57 +0200, Volker Lendecke wrote:
> > On Fri, Jun 26, 2015 at 04:38:28PM +1200, Douglas Bagnall wrote:
> > > 
> > > ...and data_blob.h is entangled with talloc. It seems to only be the
> > > DATA_BLOB struct that arcfour needs, not the talloc stuff.
> > > 
> > > Apparently sn-devel has talloc already present, so this wouldn't have
> > > been found there. An autobuild on a clean system failed like this:
> > > 
> > > In file included from ../source4/../lib/crypto/arcfour.h:4:0,
> > >                  from ../lib/crypto/arcfour.c:23:
> > > ../source4/../lib/util/data_blob.h:33:20: fatal error: talloc.h: No such
> > > file or directory
> > >  #include <talloc.h>
> > >                     ^
> > > compilation terminated.
> > > Waf: Leaving directory `/home/ubuntu/autobuild/b26732/samba-libs/bin'
> > > Build failed:  -> task failed (err #1):
> > > 	{task: cc arcfour.c -> arcfour_1.o}
> > 
> > Reviewed-by: Me.
> 
> Pushed to autobuild for now.
> Once the dependency is removed, we can
> cherry-pick the commit again. :)

So I'm kind of on the fence about this. I really like
Volker's removal of the dependencies (which I asked for)
but I also appreciate and worry about the issues separating
length and pointer (having been burned badly by C recently :-).

I certainly think the work tidying up the codebase and
separating out as many dependencies as we can is worth
doing and will try and prioritize reviews on that.

Jeremy.


More information about the samba-technical mailing list