[PATCH] Revert "lib: Fix deps for LIBCRYPTO" because arcfour need DATA_BLOB

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Jun 25 23:20:53 MDT 2015


On Fri, Jun 26, 2015 at 06:57:56AM +0200, Volker Lendecke wrote:
> On Fri, Jun 26, 2015 at 04:38:28PM +1200, Douglas Bagnall wrote:
> > 
> > ...and data_blob.h is entangled with talloc. It seems to only be the
> > DATA_BLOB struct that arcfour needs, not the talloc stuff.
> > 
> > Apparently sn-devel has talloc already present, so this wouldn't have
> > been found there. An autobuild on a clean system failed like this:
> > 
> > In file included from ../source4/../lib/crypto/arcfour.h:4:0,
> >                  from ../lib/crypto/arcfour.c:23:
> > ../source4/../lib/util/data_blob.h:33:20: fatal error: talloc.h: No such
> > file or directory
> >  #include <talloc.h>
> >                     ^
> > compilation terminated.
> > Waf: Leaving directory `/home/ubuntu/autobuild/b26732/samba-libs/bin'
> > Build failed:  -> task failed (err #1):
> > 	{task: cc arcfour.c -> arcfour_1.o}
> 
> Reviewed-by: Me.
> 
> I should have KNOWN that every time I touch lib/util I break
> something. Write down 500 times: "NEVER TOUCH LIB/UTIL".
> "NEVER TOUCH LIB/UTIL". "NEVER TOUCH LIB/UTIL". ... 

Oh, "NEVER TOUCH LIB/CRYPTO", "NEVER TOUCH LIB/CRYPTO".

Question: Why does arcfour.c have to use data_blob? Would it
be okay to liberate this from DATA_BLOB and use direct
pointers?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list