install_with_python: Secure Python download with sha256 checks.

Adrian Cochrane adrianc at catalyst.net.nz
Thu Jun 25 16:48:44 MDT 2015


Thanks for spotting that missing "|| exit 1" I should've caught. Here's 
another go with your suggested refactorings.

On Wed, Jun 24, 2015 at 12:52 PM, Martin Schwenke <martin at meltin.net> 
wrote:
> On Wed, 24 Jun 2015 10:49:00 +1000, Martin Schwenke 
> <martin at meltin.net>
> wrote:
> 
>>  [...]  Here's an example:
>> 
>>  ##############################
>>  #!/bin/sh
>>  [...]
> 
> Wow, that example was woefully incompletely, so didn't really
> illustrate the whole point.  Sorry.  :-(
> 
> Take #2:
> 
> ##############################
> #!/bin/sh
> 
> set -e
> 
> mycleanup ()
> {
>     echo "Doing cleanup"
> }
> 
> trap mycleanup 0
> 
> false
> 
> echo "We don't get here"
> ##############################
> 
> :-)
> 
> peace & happiness,
> martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-install_with_python-Secure-Python-download-with-sha2.patch
Type: text/x-patch
Size: 2337 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150626/2b6a9b0a/attachment.bin>


More information about the samba-technical mailing list