[Patches] avoid segfault in durable-open test
douglas.bagnall at catalyst.net.nz
Wed Jun 24 16:22:16 MDT 2015
Amended patches attached.
On 19/06/15 22:10, Michael Adam wrote:
> 1. in the first patch, can you do if (tree1 != NULL) instead of
> if (tree1) ?
I've taken the liberty of adding your "reviewed by" on this one
> 2. For the second patch: we try to get rid of these locally
> defined CHECK_FOO macros.
> There are macros in lib/torture/torture.h of the form
> I sugget using torture_assert_ntstatus_equal_goto().
> This is more writing than CHECK...(), but it is the
> standard way. Could you do that instead?
...but not this one.
> Thanks - Michael
> On 2015-06-19 at 16:18 +1200, Douglas Bagnall wrote:
>> hi all,
>> After my last patches, an autobuild on sn-devel segfaulted in the
>> samba3.smb2.durable-open.open2-lease(nt4_dc) test. The first of these
>> patches turns the segfault into a normal failure (or at least it would
>> if we could reproduce it). The second should make the branching in these
>> tests a little bit clearer for the next novice to wander this way.
>> I touched that file but I can't see how its related to the error.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 35489 bytes
Desc: not available
More information about the samba-technical