[PATCH] s3-libads: Use the configured LDAP page size.

Jeremy Allison jra at samba.org
Wed Jun 24 09:28:48 MDT 2015


On Wed, Jun 24, 2015 at 04:11:52PM +1200, Andrew Bartlett wrote:
> On Tue, 2015-06-23 at 16:01 -0700, Justin Maggard wrote:
> > We already allow the user to configure LDAP page size, and use it in 
> > pdb_ldap.
> > But then we hard-code the initial LDAP page size value to 1000 in 
> > ads_init, so
> > it doesn't take effect there.  So let's use the configured LDAP page 
> > size value
> > in ads_init also (defaults to 1024).
> 
> I'm concerned about the interaction between this and the 1000 default
> max search size in AD.
> 
> I don't mind if it is the minimum of the the smb.conf parameter and
> 1000, or if the smb.conf parameter defaults to 1000, but 1024 seems to
> be asking for trouble.

Ok, good point. Justin, can you also add a patch that changes
the smb.conf parameter default to 1000 (docs will need to change).

Ping me if you need help on that.

Cheers,

	Jeremy.


More information about the samba-technical mailing list