[PATCH v3] Seed random generator in main()

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Jun 24 03:18:21 MDT 2015

On Tue, Jun 23, 2015 at 09:19:35PM +0100, Robin McCorkell wrote:
> While a decision is being made on the random number generation stuff,
> the issue that this patch fixes remains a problem. At the moment,
> shuffling for MSDFS and DC referrals is woefully poor, essentially being
> the same in a given second. In addition, the built-in libc RNG is seeded
> every request, which is really inefficient.
> I know this patch isn't the way we ultimately want to go, but it does
> fix the issue at hand, so reviews please? :)

Would it also help if instead of sys_random you used
generate_random_buffer? This would avoid any further
discussion about random generators and get your patches in
more quickly I guess :-)


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list