More forest trust related patches

Andrew Bartlett abartlet at
Tue Jun 23 16:57:08 MDT 2015

On Wed, 2015-06-24 at 00:40 +0200, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> can you have a look at my current master4-forest-ok branch?

I'm in a reviewing mood, so I'll look over that.

> I added more tests and fixed some bugs, which were found.


> The master4-forest-tmp branch has one more test, which is not completely
> finished.
> (the rpc.lsa test we worked on at SambaXP). I think I just need to fix
> memory leaks
> and remove code that's commented out.
> So what's left to do before we can push it to master?

I'll work on this now. 

> I can try to add a test regarding the kvno number checking, if it turns out
> to be doable without too much work. But even without such a test I think
> it's pretty clear that the following commit is a required improvement
> compared to the current broken state. See
> Thanks!
> metze

As you would have seen, it is really, really easy to mess up the KDC
code, but don't worry, I won't hold your patch series ransom to
impossible to write tests :-)

Ideally we would write a unit test framework for the hdb layer like we
did with the bind9 dlz module, as well as the network tests.  (We could
also boil the ocean ;-)


Andrew Bartlett

Andrew Bartlett             
Authentication Developer, Samba Team
Samba Developer, Catalyst IT

More information about the samba-technical mailing list