Patches for

Jeremy Allison jra at
Mon Jun 22 17:29:00 MDT 2015

On Mon, Jun 22, 2015 at 10:23:10PM +0200, Stefan (metze) Metzmacher wrote:
> Hi,
> here're patches for
> The problem is that the source3 rpc server uses 8 byte aligned padding
> relative
> to the pdu start, while windows uses 16 byte aligned padding relative to the
> payload start. The heimdal gss_wrap() (called in
> gensec_gssapi_seal_packet()) code assumes the windows behaviour when
> working in dce_style mode. Otherwise is generated a too short signature
> 68 bytes in this cases instead of the expected 76 bytes returned by
> gensec_gssapi_sig_size().
> Please review and push.

OK, LGTM - pushed. This one:

Subject: [PATCH 06/16] s3:librpc/rpc: fix padding calculation in

too me a *long* time to figure out. Just sayin' :-).

I tried to simplify it to make it more obvious (to me)
what it was doing but couldn't. I guess that's the
sign of good code :-).

More information about the samba-technical mailing list