SV: [PATCH] make samba-tool aware of all 7 fsmo roles
davortvusir at gmail.com
Thu Jun 18 07:45:53 MDT 2015
Bravo, Rowland! Well done and congratulations.
-- Skickat från mobilusken! --
----- Ursprungligt meddelande -----
Från: "Rowland Penny" <repenny241155 at gmail.com>
Skickat: 2015-06-18 09:41
Till: ""José A. Rivera"" <jarrpa at samba.org>; "Jeremy Allison" <jra at samba.org>
Kopia: "Stefan (metze) Metzmacher" <metze at samba.org>; "Jelmer Vernooij" <jelmer at jelmer.uk>; "samba-technical" <samba-technical at lists.samba.org>
Ämne: Re: [PATCH] make samba-tool aware of all 7 fsmo roles
On 18/06/15 00:04, José A. Rivera wrote:
> LGTM. Reviewed and pushed!
> On Thu, Jun 11, 2015 at 9:11 AM, Jeremy Allison <jra at samba.org
> <mailto:jra at samba.org>> wrote:
> On Thu, Jun 11, 2015 at 12:14:07PM +0100, Rowland Penny wrote:
> > On 05/06/15 19:56, Jelmer Vernooij wrote:
> > >Thanks, looks reasonable to me - at least the Python side of
> things. Can
> > >somebody else from the team review as well and push?
> > Hi, could someone possibly have a look at my latest patch and agree
> > with Jelmer that it is usable and push it.
> > If there is still a problem with it, please let me know and I will
> > try to fix it.
> I hear you Rowland. Unfortunately I'm not good enough in python
> to reliably review this.
> Team - can we please get a second python reviewer to help Rowland get
> his first patch into Samba !
Thank you, does this make me one of the 'devs' :-D
More information about the samba-technical