[PATCH] make samba-tool aware of all 7 fsmo roles

José A. Rivera jarrpa at samba.org
Wed Jun 17 17:04:51 MDT 2015


LGTM. Reviewed and pushed!

--Jose

On Thu, Jun 11, 2015 at 9:11 AM, Jeremy Allison <jra at samba.org> wrote:

> On Thu, Jun 11, 2015 at 12:14:07PM +0100, Rowland Penny wrote:
> > On 05/06/15 19:56, Jelmer Vernooij wrote:
> > >Thanks, looks reasonable to me - at least the Python side of things. Can
> > >somebody else from the team review as well and push?
> >
> > Hi, could someone possibly have a look at my latest patch and agree
> > with Jelmer that it is usable and push it.
> > If there is still a problem with it, please let me know and I will
> > try to fix it.
>
> I hear you Rowland. Unfortunately I'm not good enough in python
> to reliably review this.
>
> Team - can we please get a second python reviewer to help Rowland get
> his first patch into Samba !
>
> Cheers,
>
>         Jeremy.
>


More information about the samba-technical mailing list