Why are we using SMB_MALLOC_ARRAY in smb2_setinfo.c

[Richard Sharpe]

On Tue, Jun 16, 2015 at 2:42 PM, Jeremy Allison <jra at samba.org> wrote:
> On Tue, Jun 16, 2015 at 09:52:10AM -0700, Jeremy Allison wrote:
>> On Mon, Jun 15, 2015 at 08:42:03AM +0200, Stefan (metze) Metzmacher wrote:
>> > Hi Richard,
>> >
>> > the following patch should fix the problem.
>>
>> Pushed with a rename of talloc_set_destructor -> defer_rename_state_destructor
>> to make it compile :-).
>
> Spoke too soon, this fix causes a crash in
> TESTS=samba3.smb2.lease with the rename:
>
> [1(0)/2 at 0s] samba3.smb2.lease(nt4_dc)
> *** Error in `./bin/smbd': free(): invalid pointer: 0x00007f3285553d30 ***

Also, while the patch tries to eliminate the memory leak, it would be
better to more to talloc and eliminate the SMB_MALLOC_ARRAY.

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)