[PATCH] heimdal - avoid an endless loop when KDC replies KRB5KDC_ERR_SVC_UNAVAILABLE

Jeremy Allison jra at samba.org
Tue Jun 16 10:19:47 MDT 2015


On Tue, Jun 16, 2015 at 06:59:02AM +0200, Volker Lendecke wrote:
> On Tue, Jun 16, 2015 at 02:12:09AM +0300, Alexander Bokovoy wrote:
> > On Tue, Jun 16, 2015 at 12:33:41AM +0300, Uri Simchoni wrote:
> > > !krb5_krbhst_retry_exceeded() is the equivalent of i<context->max_retries,
> > > krb5_krbhst_retry() at the end of the loop is the equivalent of ++i
> > > (which is also executed at the end of the loop).
> > > 
> > > So unless I'm missing something, logic hasn't changed, it's the same
> > > loop with same exit conditions as before, except the loop counter
> > > doesn't start from zero on subsequent invocation if the history has
> > > not been re-created.
> > Thanks. We actually went with Jeremy right now over the flow and we now
> > are convinced you are right.
> > 
> > Thanks, that makes two ACKs but the question is do we want to patch
> > in-tree Heimdal...
> 
> Not THIS discussion again please. Just freakin' push it.

Pushed :-).


More information about the samba-technical mailing list