[PATCH v3] Seed random generator in main()

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Jun 16 08:23:32 MDT 2015

On Mon, Jun 15, 2015 at 12:34:06PM +0100, Robin McCorkell wrote:
> Remove srandom() from DFS shuffling, only seed once during process init.
> Improves performance and gives better shuffling.
> Use of random() replaced with sys_random() in places to improve
> protection against renamed libc functions

Just to give you a quick ack: Randomness is not an easy
topic to review unfortunately. There's just two kinds of
randomness we require: Cryptographically good for nonces and
passwords and just "junk" randomness for everything else.
For the "junk" randomness it's important for testability
that it's seedable, I'm not sure about that requirement for
the crypto randomness.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list