First fixes for https://bugzilla.samba.org/show_bug.cgi?id=11141 (11316)

Stefan (metze) Metzmacher metze at samba.org
Tue Jun 16 06:50:28 MDT 2015


Am 15.06.2015 um 20:40 schrieb Jeremy Allison:
> On Thu, Jun 11, 2015 at 02:09:32PM -0700, Jeremy Allison wrote:
>> On Mon, Jun 08, 2015 at 10:45:36AM +0200, Stefan (metze) Metzmacher wrote:
>>> Hi,
>>>
>>> here're fixes which should fix the generic problem which can happen
>>> in a lot of other places too.
>>>
>>> I choose to use the tdgram/tstream abstraction in non performance critical
>>> places, as it has the prevention of this bug builtin.
>>> In other places I kept the low-level read_packet_send/recv and
>>> writev_send/recv
>>> calls and added the protection by hand.
>>>
>>> I've create a new bug report here:
>>> https://bugzilla.samba.org/show_bug.cgi?id=11316
>>>
>>> Please review carefully and push.
>>
>> Just FYI, I'm reviewing carefully and am pushing the
>> first few.
> 
> FYI. autobuild failed for unrelated issues (gah!).
> But looks like you got them pushed anyway :-).

Yes, but it's good that you also looked at the patches.

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150616/2bbddfc4/attachment.pgp>


More information about the samba-technical mailing list