[PATCH] heimdal - avoid an endless loop when KDC replies KRB5KDC_ERR_SVC_UNAVAILABLE

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Jun 15 22:59:02 MDT 2015


On Tue, Jun 16, 2015 at 02:12:09AM +0300, Alexander Bokovoy wrote:
> On Tue, Jun 16, 2015 at 12:33:41AM +0300, Uri Simchoni wrote:
> > !krb5_krbhst_retry_exceeded() is the equivalent of i<context->max_retries,
> > krb5_krbhst_retry() at the end of the loop is the equivalent of ++i
> > (which is also executed at the end of the loop).
> > 
> > So unless I'm missing something, logic hasn't changed, it's the same
> > loop with same exit conditions as before, except the loop counter
> > doesn't start from zero on subsequent invocation if the history has
> > not been re-created.
> Thanks. We actually went with Jeremy right now over the flow and we now
> are convinced you are right.
> 
> Thanks, that makes two ACKs but the question is do we want to patch
> in-tree Heimdal...

Not THIS discussion again please. Just freakin' push it.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list