[PATCH] libads: Fix fallback logic when finding a domain controller

Alexander Bokovoy ab at samba.org
Mon Jun 15 12:08:48 MDT 2015


Hi,

On Thu, Jun 11, 2015 at 02:37:40PM +0300, Uri Simchoni wrote:
> Hopefully I captured everything - here's V2, split into two commits:
> 
> 1/2 - same as V1 1/1, but with a modified commit message and hopefully
> capturing the coding-style comments.
> 2/2 - further splitting the new resolve_and_ping into dns and netbios
> variants - I figured this belongs on a separate commit because
> extracting code into a function is hard enough to review, let alone
> into two functions.
Reviewed-by: me. Looks like a great improvement, thanks!

Jeremy, you have second review. ;)

-- 
/ Alexander Bokovoy


More information about the samba-technical mailing list