[PATCH] tdb: Check for sigaction in the standalone build

Amitay Isaacs amitay at gmail.com
Wed Jun 10 06:20:57 MDT 2015


Hi Volker,

On Wed, Jun 10, 2015 at 9:21 PM, Volker Lendecke <Volker.Lendecke at sernet.de>
wrote:

> Hi!
>
> This fixes bug 11326.
>
> Review&push appreciated!
>
> Thanks,
>
> Volker
>
>
I think we always want to do the check for sigaction and not just for
standalone builds.  Any other project using tdb and building with waf might
get a nasty surprise trying to use mutexes.

How about following patch instead?  It adds it only if
disable_tdb_mutex_locking is not true.

diff --git a/lib/tdb/wscript b/lib/tdb/wscript
index f63f750..ee8df5f 100644
--- a/lib/tdb/wscript
+++ b/lib/tdb/wscript
@@ -71,6 +71,7 @@ def configure(conf):
                                                  False)
     if not conf.env.disable_tdb_mutex_locking:
         conf.env.replace_add_global_pthread = True
+        conf.CHECK_FUNCS('sigaction')
     conf.RECURSE('lib/replace')

     conf.env.standalone_tdb = conf.IN_LAUNCH_DIR()

Amitay.


More information about the samba-technical mailing list