[PATCH] libads: Fix fallback logic when finding a domain controller

Uri Simchoni urisimchoni at gmail.com
Tue Jun 9 13:19:13 MDT 2015

Oops once again with the patch...

On Tue, Jun 9, 2015 at 10:18 PM, Uri Simchoni <urisimchoni at gmail.com> wrote:
> This is a patch to fix bug 11321.
> Basically when finding a domain controller, the method is to resolve
> the IP address of candidate servers, and then do an ldap ping until a
> suitable server answers.
> In case of failure, there's fallback from DNS lookup to netbios lookup
> (if netbios is enabled) and then back to site-less DNS lookup. The two
> problems here are:
> 1. It makes more sense to try site-less DNS before NetBIOS because the
> fallback to NetBIOS is not likely to give better results.
> 2. The NetBIOS fallback screws the site-less fallback (I suppose the
> "goto considered harmful fellows are sometimes right after all...).
> This fix extracts the core code that does name resolving+ldap ping
> into a separate function and then activates this function in up to
> three modes - site-aware, site-less, and netbios, in that order.
> Thanks,
> Uri.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: site-fb.patch
Type: application/octet-stream
Size: 8855 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150609/2ea7f433/attachment.obj>

More information about the samba-technical mailing list