[PATCHES] ctdb - slightly refactor the vacuum_fetch loop
amitay at gmail.com
Fri Jun 5 00:54:25 MDT 2015
On Fri, Jun 5, 2015 at 3:53 PM, Michael Adam <obnox at samba.org> wrote:
> Hi Amitay,
> Thanks for your comments.
> On 2015-06-05 at 10:57 +1000, Amitay Isaacs wrote:
> > Hi Michael,
> > On Thu, Jun 4, 2015 at 4:26 PM, Michael Adam <obnox at samba.org> wrote:
> > > Review etc appreciated!
> > >
> > > Cheers - Michael
> > >
> > The reworking looks good.
> > For the second last patch that converts while loop into for
> > loop, I would prefer not to overload the for loop assignments
> > and conditions. Keep only iterator variables in the for
> > statement and move other assignments and conditions in the body
> > of the loop.
> Hmm I had thought about this back and forth, and actually
> liked the way, but I just realized that I even missed the
> in-loop initialization of r = v->r ... ;) So I now kept the
> while-loop and just moved the advancing code to the end.
> What do you think?
> > Also, if you don't mind can you use "ctdb-foobar:" instead of
> > "ctdb:foobar:" in the commit messages? It makes easier to import the
> > patches to 2.5 with a script. :-)
> Updated version attached.
> Thanks - Michael
I have added my Reviewed-by tags. Also added 2 patches that do some more
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 17245 bytes
Desc: not available
More information about the samba-technical