[PATCH] libads: fixes to generation of custom krb5.conf
jra at samba.org
Thu Jun 4 14:03:12 MDT 2015
On Thu, Jun 04, 2015 at 10:39:38PM +0300, Uri Simchoni wrote:
> OK here's version 2 with the 88 literal removed.
> Patch v2 1/5 - same as v1 1/4
> Patch v2 2/5 - same as v1 2/4
> Patch v2 3/5 - move DEFAULT_KRB5_PORT to kerberos_proto.h
> Patch v2 4/5 - same as v1 3/4 except DEFAULT_KRB5_PORT instead of 88
> Patch v2 5/5 - same as v1 4/4
> Thanks for reviewing!
> On Thu, Jun 4, 2015 at 10:18 PM, Jeremy Allison <jra at samba.org> wrote:
> > On Thu, Jun 04, 2015 at 10:00:09PM +0300, Uri Simchoni wrote:
> >> DEFAULT_KRB5_PORT is in kerberos.c. Can someone suggest a good place
> >> to put it, so that both namequery.c (which is about name resolving -
> >> DNS) and kerberos.h (which is about.. kerberos) can see it?
> > Ah, good point. I would suggest moving it to:
> > source3/libads/kerberos_proto.h
> > and then including that in namequery.c.
Reviewed-by: Jeremy Allison <jra at samba.org>
Can I get a second Team reviewer ?
More information about the samba-technical