[PATCH] winbindd: control number of winbindd's client connections
jra at samba.org
Wed Jun 3 13:05:36 MDT 2015
On Wed, Jun 03, 2015 at 09:46:08PM +0300, Uri Simchoni wrote:
> Well, if the user has one less parameter to worry about...
> In principle we should accept new connections if the number of clients
> is below limit, and the existing parameter (winbind max clients)
> handles that. Waiting further until we're 10% below the limit saves
> some stop/start accepting events, which has a marginal positive effect
> on performance (save some system calls in case of epoll) and is easier
> on the log file (since hitting the limit generates a log). It looked
> to me that this didn't justify a new parameter.
> One other point is that hitting the maximum is to be avoided (hence it
> generates a level-0 log) because it makes clients reopen connections
> all the time, and therefore the user is expected to fine-tune the max
> number of client connections (and possibly max number of domain
> connections) in order to prevent the limit from being reached, and not
> to fine-tune the system behavior when the limit is reached.
> If you remain unconvinced, I can add a parameter.
Personally I like the heuristic - the less the
user has to configure the better.
IMHO we should only add parameters for things that
can break or materially change behavior, I don't
think this applies.
FYI, I'm still reviewing this change (only thing
I can see so far is to change the 'int' counter
to an unsigned int (counts can't go negative)
but at first glance it looks really good !
More information about the samba-technical