[PATCH] group.py: Fix wrong example option, remove wrong comment line
obnox at samba.org
Wed Jun 3 03:59:06 MDT 2015
the change is good, but I'd encourage you to split
it into two commits: They are only related by changing
the same file.
If a commit message reads "do foo AND bar"
is an indication that you want it to be two
commits "do foo" and "do bar", is my mantra here.
I'll re-review/push when you resubmit.
Cheers - Michael
On 2015-06-03 at 07:41 +0200, Marc Muehlfeld wrote:
> attached a patch, with two tiny fixes for python/samba/netcmd/group.py.
> Please review and push.
> Thanks to Rowland, for finding that. I created a bug report, to track
> this: https://bugzilla.samba.org/show_bug.cgi?id=11072
> Am 24.01.2015 um 13:51 schrieb Rowland Penny:
> > The other thing that is puzzling me is '--gid=12345', yet in the
> > script there is this:
> > Option("--gid-number", help="Group's Unix/RFC2307 GID number",
> > type=int),
> > ....
> > Just one last comment, the first line of group.py is this:
> > # Adds a new user to a Samba4 server
> > ????
> > Rowland
> >From b15278afd88de29d88d143433e732e797e11357a Mon Sep 17 00:00:00 2001
> From: Marc Muehlfeld <mmuehlfeld at samba.org>
> Date: Sat, 24 Jan 2015 15:59:40 +0100
> Subject: [PATCH] group.py: Fix wrong example option, remove wrong comment line
> Replaced "--gid" with the correct "--gid-number" in Example 3.
> Additionally removed the first comment line in group.py, which
> was wrong in that file.
> Signed-off-by: Marc Muehlfeld <mmuehlfeld at samba.org>
> python/samba/netcmd/group.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> diff --git a/python/samba/netcmd/group.py b/python/samba/netcmd/group.py
> index 4b5fd27..722bcc4 100644
> --- a/python/samba/netcmd/group.py
> +++ b/python/samba/netcmd/group.py
> @@ -1,4 +1,3 @@
> -# Adds a new user to a Samba4 server
> # Copyright Jelmer Vernooij 2008
> # Based on the original in EJS:
> @@ -72,7 +71,7 @@ sudo samba-tool group add Group2 --group-type=Distribution
> Example2 adds a new distribution group to the local server. The command is run under root using the sudo command.
> -samba-tool group add Group3 --nis-domain=samdom --gid=12345
> +samba-tool group add Group3 --nis-domain=samdom --gid-number=12345
> Example3 adds a new RFC2307 enabled group for NIS domain samdom and GID 12345 (both options are required to enable this feature).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the samba-technical