[PART4] [PATCHES] generate the param_table (FINALLY)
Michael Adam
obnox at samba.org
Fri Jul 31 07:32:17 UTC 2015
Hi Andrew,
Thanks for your comment!
On 2015-07-31 at 18:08 +1200, Andrew Bartlett wrote:
> On Wed, 2015-07-29 at 12:20 +0200, Michael Adam wrote:
> > Hi,
> >
> > FYI: I have rebased the branch mentioned below.
> > The code still cleanly applies and builds...
> >
> > :-)
> >
> > Cheers - Michael
>
> My only comment is regarding:
>
> param: don't list '-valid' and 'copy' as synonyms - they aren't
>
> Signed-off-by: Michael Adam <obnox at samba.org>
>
> Because in e629d390f5ab5d3d74c6e5267f17585916e50950 you renamed
> FLAG_HIDE to FLAG_SYNONYM, and both copy and -valid should be hidden.
>
> Have you confirmed -valid and copy are still hidden correctly?
Hiding does not exist any more: it was a concept in SWAT.
copy and -valid were examples where the rather automatic
renaming of FLAG_HIDE to FLAG_SYNONYM was not correct,
since these are not synonyms. This is fixed by this new change.
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150731/3a4892ee/attachment.sig>
More information about the samba-technical
mailing list