[PART4] [PATCHES] generate the param_table (FINALLY)

Andrew Bartlett abartlet at samba.org
Fri Jul 31 06:08:11 UTC 2015


On Wed, 2015-07-29 at 12:20 +0200, Michael Adam wrote:
> Hi,
> 
> FYI: I have rebased the branch mentioned below.
> The code still cleanly applies and builds...
> 
> :-)
> 
> Cheers - Michael

My only comment is regarding:

param: don't list '-valid' and 'copy' as synonyms - they aren't
    
    Signed-off-by: Michael Adam <obnox at samba.org>

Because in e629d390f5ab5d3d74c6e5267f17585916e50950 you renamed
FLAG_HIDE to FLAG_SYNONYM, and both copy and -valid should be hidden. 

Have you confirmed -valid and copy are still hidden correctly?

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba




-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150731/d57d8b6e/signature.sig>


More information about the samba-technical mailing list