[PATCHES] cluster api testing patches
Jeremy Allison
jra at samba.org
Thu Jul 30 16:47:17 UTC 2015
On Fri, Jul 24, 2015 at 03:04:40PM +0200, Guenther Deschner wrote:
> Hi,
>
> attached are some more patches for testing the cluster management
> interface, notably the marshalling of the PROPERTY_LIST buffers.
>
> Please review and push.
LGTM - pushing. One comment though. In new code you
do a lot of stuff like:
struct clusapi_XXXXXXXXXXXXXXXXXXXXXXXX r;
r.xxx = XXX
r.yyy = YYY
...
r is on the stack, so I'd like to get into
the habit of doing.
struct clusapi_GetResourceNetworkName r = { 0 };
when declaring, instead of having to add a
ZERO_STRUCT(r);
Argg... Doesn't work with gcc warnings,
never mind :-).
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119
But think about adding ZERO_STRUCT(r)'s in
future..
More information about the samba-technical
mailing list