[PATCH] source3 torture: don't segfault if filename query fails

[Jeremy Allison]

On Fri, Jul 17, 2015 at 06:31:25PM +1200, Douglas Bagnall wrote:
> An unset string caused a segfault in a test. It seems it hasn't failed
> since 2002.

Reviewed-by: Jeremy Allison <jra at samba.org>

Second Team reviewer ?

> >From 4918ffa8f32711a405ffa8c0cab5646d30051a7b Mon Sep 17 00:00:00 2001
> From: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
> Date: Thu, 9 Jul 2015 14:17:50 +1200
> Subject: [PATCH 3/4] source3 torture: don't segfault if filename query fails
> 
> If the query return status is not OK, the query answer pointer could
> be uninitialised.
> 
> Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
> ---
>  source3/torture/torture.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/source3/torture/torture.c b/source3/torture/torture.c
> index bfd04f4..e0be44e 100644
> --- a/source3/torture/torture.c
> +++ b/source3/torture/torture.c
> @@ -3264,8 +3264,7 @@ static bool run_trans2test(int dummy)
>  		printf("ERROR: qfilename failed (%s)\n", nt_errstr(status));
>  		correct = False;
>  	}
> -
> -	if (strcmp(pname, fname)) {
> +	else if (strcmp(pname, fname)) {
>  		printf("qfilename gave different name? [%s] [%s]\n",
>  		       fname, pname);
>  		correct = False;
> -- 
> 1.9.1
>