[PATCH 0/5] dns: Add authority record to replies

Andreas Schneider asn at samba.org
Thu Jul 30 10:04:37 UTC 2015


On Thursday 30 July 2015 11:53:19 Kai Blin wrote:
> Patchset to add an "authority" record to all replies that we are
> authoritative for. This should fix bug #10153
> 
> Kai Blin (5):
>   dns: Add dns_get_authoritative_zone helper function
>   dns: Just pass the name to create_response_rr
>   dns: Also pass nsrecs to handle_question()
>   dns: Add a SOA record to error replies
>   dns: always add authority records
> 
>  python/samba/tests/dns.py       | 34 +++++++--------
>  source4/dns_server/dns_query.c  | 96
> ++++++++++++++++++++++++++++++++++------- source4/dns_server/dns_server.c |
>  7 ++-
>  source4/dns_server/dns_server.h |  2 +
>  source4/dns_server/dns_utils.c  | 16 +++++++
>  5 files changed, 121 insertions(+), 34 deletions(-)

If the patchset is correct. Then you should be able to pass 'make test' with 
the following patch ...

 selftest/wscript | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/selftest/wscript b/selftest/wscript
index 61ca0bd..1caec35 100644
--- a/selftest/wscript
+++ b/selftest/wscript
@@ -207,12 +207,8 @@ def cmd_testonly(opt):
     env.OPTIONS += " --socket_wrapper_so_path=" + CONFIG_GET(opt, 
'LIBSOCKET_WRAPPER_SO_PATH')
     env.OPTIONS += " --uid_wrapper_so_path=" + CONFIG_GET(opt, 
'LIBUID_WRAPPER_SO_PATH')
 
-    #if unversioned_sys_platform in ('freebsd', 'netbsd', 'openbsd', 
'sunos'):
-    #    env.OPTIONS += " --use-dns-faking"
-
-    # FIXME REMOVE ME!
-    env.OPTIONS += " --use-dns-faking"
-
+    if unversioned_sys_platform in ('freebsd', 'netbsd', 'openbsd', 'sunos'):
+        env.OPTIONS += " --use-dns-faking"
 
     subunit_cache = None
     # We use the full path rather than relative path to avoid problems on 
some platforms (ie. solaris 8).


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list