[PATCH] remove unneeded prototype (Re: [PATCHES] prepare session lookup ... multi-channel)

Michael Adam obnox at samba.org
Thu Jul 30 07:12:17 UTC 2015


On 2015-07-29 at 12:12 +0200, Michael Adam wrote:
> Hi,
> 
> This is a patchset that comes as a preparation for
> multi-channel. It prepares the code to do correct
> validation of connections as channels on the session
> in the appropriate places under the right conditions:
> Basically, if the request is a channel bind, we do
> not have the connection bound yet, so should not
> validate it. (More precisely, when in a later step,
> the binding session setup is implemented, we need
> to verify that the connection does *not* belong to
> the session as a channel yet..)
> 
> This patchset was done in collaboration with Metze
> and already carries enough review/signoff, so I will
> push it later if noone raises objections.

It has meanwhile landed in master.

I noticed that a prototype has now become unnecessary
in smbXsrv_session.c. Attached is a patch to remove it.

Review appreciated.

Cheers - Michael
-------------- next part --------------
From f0e793c9da9c0b196caa9dd8ae30a5fd854d86cd Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Wed, 29 Jul 2015 18:23:31 +0200
Subject: [PATCH] s3:smb2_sesssetup: remove now unneeded declaration of
 smb2srv_session_lookup_raw

Signed-off-by: Michael Adam <obnox at samba.org>
---
 source3/smbd/smbXsrv_session.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/source3/smbd/smbXsrv_session.c b/source3/smbd/smbXsrv_session.c
index ff4f14f..17ba401 100644
--- a/source3/smbd/smbXsrv_session.c
+++ b/source3/smbd/smbXsrv_session.c
@@ -51,12 +51,6 @@ struct smbXsrv_session_table {
 	} global;
 };
 
-static NTSTATUS smb2srv_session_lookup_raw(struct smbXsrv_session_table *table,
-					   /* conn: optional */
-					   struct smbXsrv_connection *conn,
-					   uint64_t session_id, NTTIME now,
-					   struct smbXsrv_session **session);
-
 static struct db_context *smbXsrv_session_global_db_ctx = NULL;
 
 NTSTATUS smbXsrv_session_global_init(void)
-- 
2.4.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150730/881678cf/attachment.sig>


More information about the samba-technical mailing list