[PATCH] lib/param: move function declaration to after forward declaration of struct loadparm_context

[Michael Adam]

The change is good, as discussed last night on IRC.

Minor nit-pick regarding the commit msg:
It is not _really_ a function declaration but
a typedef (of a function type) that you are
moving. :-) But I won't NACK on this.

Reviewed-by: Michael Adam <obnox at samba.org>

Cheers - Michael

On 2015-07-30 at 11:34 +1000, Brad Hards wrote:
> Avoids a warning about the structure being declared inside the parameter list.
> 
> Signed-off-by: Brad Hards <bradh at frogmouth.net>
> ---
>  lib/param/param.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/param/param.h b/lib/param/param.h
> index af321e1..25be9dd 100644
> --- a/lib/param/param.h
> +++ b/lib/param/param.h
> @@ -34,26 +34,26 @@ struct param_section {
>  	struct parmlist *parameters;
>  };
>  
>  struct param_context;
>  struct smbsrv_connection;
>  
> -typedef bool (*lpcfg_defaults_hook) (struct loadparm_context *);
> -
>  #define Auto (2)
>  
>  #include "libds/common/roles.h"
>  
>  struct loadparm_context;
>  struct loadparm_service;
>  struct smbcli_options;
>  struct smbcli_session_options;
>  struct gensec_settings;
>  struct bitmap;
>  struct file_lists;
>  
> +typedef bool (*lpcfg_defaults_hook) (struct loadparm_context *);
> +
>  #ifdef CONFIG_H_IS_FROM_SAMBA
>  #include "lib/param/param_proto.h"
>  #include "lib/param/param_functions.h"
>  #endif
>  
>  const char **lpcfg_interfaces(struct loadparm_context *);
> -- 
> 1.9.1
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150730/96e5fc0c/attachment.sig>