Patches to for type consistency in Python pidl

Andrew Bartlett abartlet at samba.org
Tue Jul 28 21:42:20 UTC 2015


On Fri, 2015-06-26 at 09:07 +0000, Jelmer Vernooij wrote:
> Hi Douglas,
> 
> Thanks for working on pidl! Some comments below:
> 
> On Thu, Jun 25, 2015 at 06:20:33PM +1200, Douglas Bagnall wrote:
> > From 9c6661748f75d8aaf00b6a1a0ec1aff3a7a63b89 Mon Sep 17 00:00:00 
> > 2001
> > From: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
> > Date: Thu, 18 Jun 2015 12:38:22 +1200
> > Subject: [PATCH 1/6] Treat uid_t, gid_t as 64 bit in Pidl Python 
> > bindings
> > 
> > This follows their treatment in librpc/ndr/ndr_basic.c.
> > 
> > 
> > Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
> 
> Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
> 
> That said, we should just remove uid_t and gid_t from Pidl, and just
> make them aliases for uint64_t.

How do we do that but still keep them as distinct types in C?

I'm not saying they belong in PIDL, but I've only found the way to make
IDL types (that are not C types, things like DWORD) an alias, but not
the other way around.

BTW, as you would have seen from my other patch (sorting
replPropertyMetaData correctly), this area has gone from an interesting
research project to being on the critical path to fixing upgrades from
4.1 to 4.2, so any assistance you can give would be most helpful.

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba








More information about the samba-technical mailing list