smbtorture failure

[Herb Lewis]

well after building smbtorture without the talloc_free(cli1) in 
run_tcon_test the test
now fails against Windows 8.1 and Windows 2012 server with the following 
error.
Looks like Microsoft changed the behaviour for a second tree connect

failure: tcon [
mauvm25-2 refused 2nd tree connect (NT_STATUS_DUPLICATE_NAME)

On 07/23/2015 11:11 AM, Herb Lewis wrote:
> I'm seeing a panic in smbtorture base.tcon when run against a Windows 
> 8.1 machine
> but it works against Windows 7.
>
> [root at mauvm12-4 ~]# smbtorture //mauvm25-2/temp -U 
> qa-2k-mm\\administrator%123 base.tcon
> smbtorture 4.2.2-SerNet-RedHat-18.el6
> Using seed 1437674267
> time: 2015-07-23 10:57:47.781066
> test: tcon
> time: 2015-07-23 10:57:47.781235
> talloc: access after free error - first free may be at 
> ../source4/torture/basic/base.c:450
> Bad talloc magic value - access after free
> PANIC: Bad talloc magic value - access after free
> Aborted (core dumped)
>
>
> static bool run_tcon_test(struct torture_context *tctx, struct 
> smbcli_state *cli)
> has the following code
>
>         if (NT_STATUS_IS_ERR(smbcli_tconX(cli, share, "?????", 
> password))) {
>                 torture_result(tctx, TORTURE_FAIL, "%s refused 2nd 
> tree connect (%s)\n", host,
>                            smbcli_errstr(cli->tree));
>                 talloc_free(cli);
>                 return false;
>         }
>
> but this is called by  wrap_simple_1smb_test which has the following code
>
>         ret = fn(torture_ctx, cli1);
> fail:
>         talloc_free(cli1);
>
>
> so we try to double free the cli1 pointer
>