[PATCHES] avoid searching for wellknownobjects when not needed, cache results for speed

[Andrew Bartlett]

On Tue, 2015-05-26 at 05:46 -0700, Matthieu Patou wrote:
> On 05/25/2015 09:54 PM, Andrew Bartlett wrote:
> > On Mon, 2015-05-25 at 21:50 -0700, Matthieu Patou wrote:
> > > Hello All,
> > > 
> > > Please find attached 2 patches that reduce the time of dbcheck by 
> > > 10%,
> > > they avoid calling getwellknowobjects when not needed (ie. when 
> > > dealing
> > > with the schema NC) and also cache the result of the function as 
> > > well
> > > known object didn't change.
> > > 
> > > Pass make test.
> > As we got into the unfortunate situation where dbcheck was marked 
> > as
> > flapping, sadly this means this code is untested in 'make test'.  :
> > -(
> > 
> > Andrew Bartlett
> > 
> Ok but still it doesn't mean that those changes are wrong.
> One of those is to cache the wellknownobjects when found; as the name 
> 
> imply the wellknownobjects doesn't change. Also I think I did several 
> 
> rounds of make tests without getting an error so if let's say 3 
> rounds 
> of make test didn't show any regression we can treat this as a 
> reliable 
> patch no ?

Now that we have removed a cause of flapping dbcheck tests, can you
remove dbcheck as flapping, do some runs and see if it still flapping? 

That would allow us to consider this patch again, which would be a very
good thing.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba