[PART2] [PATCHES] some cleanup to loadparm

[Ira Cooper]

commit 87e2a4925a58db159452b3d9959cc36ecd24e202
Author: Michael Adam <obnox at samba.org>
Date:   Mon Jun 15 23:45:45 2015 +0200

    param: rename szLdapGroupSuffix -> _ldap_group_suffix

    Signed-off-by: Michael Adam <obnox at samba.org>

Does not compile.

[1321/4027] Compiling lib/param/util.c
[1322/4027] Compiling lib/param/param_table.c
[1323/4027] Compiling default/python/samba_python.empty.c
../lib/param/param_table.c:2821:13: error: ‘struct loadparm_global’ has no
member named ‘_ldap_group_suffix’
   .offset  = GLOBAL_VAR(_ldap_group_suffix),
             ^
[1324/4027] Compiling python/modules.c
Waf: Leaving directory `/home/ira/samba/obnox/bin'
Build failed:  -> task failed (err #1):
    {task: cc param_table.c -> param_table_8.o}
Makefile:8: recipe for target 'all' failed
make: *** [all] Error 1
ira at ira-t430:~/samba/obnox
[/dev/pts/1](240/2)$ git log
commit 87e2a4925a58db159452b3d9959cc36ecd24e202
Author: Michael Adam <obnox at samba.org>
Date:   Mon Jun 15 23:45:45 2015 +0200

    param: rename szLdapGroupSuffix -> _ldap_group_suffix

    Signed-off-by: Michael Adam <obnox at samba.org>


----

(Compile done on Fedora 22.)

I suspect that the other commits in the same pattern won't compile.

Thanks,

-Ira

On Wed, Jul 22, 2015 at 2:19 PM, Ira Cooper <ira at samba.org> wrote:

> Reviewing these and the 1st set....
>
> -Ira
>
> On Wed, Jul 22, 2015 at 2:06 PM, Michael Adam <obnox at samba.org> wrote:
>
>> Here comes the second set of patches.
>> (To be applied on top of the previous one.)
>> This patchset further systematizes the data and
>> how the loadparm code is generated from the docs.
>> It removes several special cases and greatly
>> shrinks LOADPARM_EXTRA_LOCALS/_GLOBALS.
>> The patches are numerous but mostly trivial.
>>
>> Review appreciated!
>>
>> Next patchset on top will be the auto-generation
>> of param_table.c. I am currently working on
>> some more check scripts to make sure it is
>> really 100% correct. ;-)
>>
>> Cheers - Michael
>>
>> On 2015-07-22 at 10:34 +0200, Michael Adam wrote:
>> > gosh, forgot one patch to teach the docs.py
>> > test about boolean-rev.
>> >
>> > Attached an update patchset including this patch.
>> >
>> > Michael
>> >
>> > On 2015-07-22 at 10:14 +0200, Michael Adam wrote:
>> > > Hi,
>> > >
>> > > some time ago, I started to work on cleaning up
>> > > our (two) loadparm(s) as a side project. The main
>> > > goal is to ultimately have all code that holds the
>> > > data structures auto-generated (from the docs),
>> > > especially param_table.c.
>> > >
>> > > I am getting closer, so here is a first set of preparatory
>> > > patches.  One aspect is to prepare the headers in the xml docs
>> > > to contain the necessary items that are reflected in the
>> > > param-table. This first patchset contains the easy ones.
>> > > This patchset is only big because it also contains a patch
>> > > that makes formatting of the metadata headers in the
>> > > docs-xml/smbdotconf/ file uniform, making them much easier
>> > > to read (imho). See with git show -w that this patch has
>> > > no non-whitespace change (only a few line breaks visible).
>> > >
>> > > Following patchsets will remove special treatments of
>> > > several parameters (from the infamous
>> > > EXTRA_LOCALS/GLOBALS...), add more flags to the docs
>> > > and finally autogenerate the param_table.c.
>> > >
>> > > Review appreciated,
>> > >
>> > > Cheers - Michael
>> > >
>> >
>>
>>
>