[PART2] [PATCHES] some cleanup to loadparm

Ira Cooper ira at samba.org
Wed Jul 22 18:19:08 UTC 2015


Reviewing these and the 1st set....

-Ira

On Wed, Jul 22, 2015 at 2:06 PM, Michael Adam <obnox at samba.org> wrote:

> Here comes the second set of patches.
> (To be applied on top of the previous one.)
> This patchset further systematizes the data and
> how the loadparm code is generated from the docs.
> It removes several special cases and greatly
> shrinks LOADPARM_EXTRA_LOCALS/_GLOBALS.
> The patches are numerous but mostly trivial.
>
> Review appreciated!
>
> Next patchset on top will be the auto-generation
> of param_table.c. I am currently working on
> some more check scripts to make sure it is
> really 100% correct. ;-)
>
> Cheers - Michael
>
> On 2015-07-22 at 10:34 +0200, Michael Adam wrote:
> > gosh, forgot one patch to teach the docs.py
> > test about boolean-rev.
> >
> > Attached an update patchset including this patch.
> >
> > Michael
> >
> > On 2015-07-22 at 10:14 +0200, Michael Adam wrote:
> > > Hi,
> > >
> > > some time ago, I started to work on cleaning up
> > > our (two) loadparm(s) as a side project. The main
> > > goal is to ultimately have all code that holds the
> > > data structures auto-generated (from the docs),
> > > especially param_table.c.
> > >
> > > I am getting closer, so here is a first set of preparatory
> > > patches.  One aspect is to prepare the headers in the xml docs
> > > to contain the necessary items that are reflected in the
> > > param-table. This first patchset contains the easy ones.
> > > This patchset is only big because it also contains a patch
> > > that makes formatting of the metadata headers in the
> > > docs-xml/smbdotconf/ file uniform, making them much easier
> > > to read (imho). See with git show -w that this patch has
> > > no non-whitespace change (only a few line breaks visible).
> > >
> > > Following patchsets will remove special treatments of
> > > several parameters (from the infamous
> > > EXTRA_LOCALS/GLOBALS...), add more flags to the docs
> > > and finally autogenerate the param_table.c.
> > >
> > > Review appreciated,
> > >
> > > Cheers - Michael
> > >
> >
>
>


More information about the samba-technical mailing list