install_with_python: Secure Python download with sha256 checks.

Martin Schwenke martin at meltin.net
Wed Jul 22 05:30:19 UTC 2015


On Wed, 22 Jul 2015 16:12:45 +1200, Andrew Bartlett
<abartlet at samba.org> wrote:

> On Fri, 2015-06-26 at 10:48 +1200, Adrian Cochrane wrote:
> > Thanks for spotting that missing "|| exit 1" I should've caught. 
> > Here's 
> > another go with your suggested refactorings.
> 
> Martin,
> 
> What do you think of this?  It isn't perfect, but it is an improvement
> and so I would like to get this in.
> 
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>

I was waiting for someone to chime in who knew what the original code
did...  :-)

Yep, I agree:

Reviewed-by: Martin Schwenke <martin at meltin.net>

peace & happiness,
martin



More information about the samba-technical mailing list