[PATCH] notifyd: fix memory alignment

Jeremy Allison jra at samba.org
Sun Jul 19 03:30:46 UTC 2015


On Sat, Jul 18, 2015 at 09:52:28PM +0200, Volker Lendecke wrote:
> On Fri, Jul 17, 2015 at 11:12:46AM -0700, Jeremy Allison wrote:
> > On Thu, Jul 16, 2015 at 09:47:53PM +0300, Uri Simchoni wrote:
> > > Best thing is to set up the DB fetching in a way that the data is
> > > aligned when fetched (the parse function can verify this). I'll look
> > > into it but xtdb experts can look into it without the learning curve.
> > > Second best option is to have an array that grows as-needed. This
> > > removes the allocations but not the copying.
> > 
> > Yeah, we can't avoid the memcpy I think (if you can
> > think of a way I'm very interested).
> 
> What about the attached patch? Survives an initial small
> test for me.

Oh you fixed it in the dbwrap layer. That's cheating :-).



More information about the samba-technical mailing list