[PATCH] Do not ignore the block size of the dfree command - brc #11403

Ralph Böhme rb at sernet.de
Fri Jul 17 10:33:43 UTC 2015


On Fri, Jul 17, 2015 at 11:45:15AM +0200, Andreas Schneider wrote:
> On Friday 17 July 2015 09:54:38 Andreas Schneider wrote:
> > Hi,
> > 
> > attached find a patch to fix
> > https://bugzilla.samba.org/show_bug.cgi?id=11403
> 
> New version with a simple test for the dfree command.

two issues:

- the global declaration of dfree_broken must be removed

- imo the error code path in the case (lines == NULL) could be
  simplified

Fixups attached.

Other then that: reviewed by me.

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de



More information about the samba-technical mailing list