[PATCH] correct order of include files to include replace.h first
Jeremy Allison
jra at samba.org
Thu Jul 16 23:26:14 UTC 2015
On Fri, Jul 17, 2015 at 12:48:27AM +0200, Stefan (metze) Metzmacher wrote:
> Hi Jeremy,
> >> v2 7/8 - fix vfs_btrfs.c
> >> v2 8/8 - change replace.h to prevent such errors in the future
> >
> > Reviewed-by: Jeremy Allison <jra at samba.org>
> >
> > Can I get a second Team reviewer ?
>
> See my comments below...
...
> >> #include <libgen.h>
> >> -#include "system/filesys.h"
> >> -#include "includes.h"
>
> This looks still wrong "includes.h" should be the first one
> and "system/filesys.h" should be kept as 2nd, some of the other
> might not be needed anymore then.
....
>
> #error "config.h must be included before any glibc header file"
>
> should be something like this:
>
> #error "config.h via replace.h must be included before any glibc header
> file"
>
> in order to indicate that this check comes from replace.h.
>
> Otherwise Reviewed-by: Stefan Metzmacher <metze at samba.org>
OK, I'll push everything except the last 2 and we can
work those out together with Uri.
Cheers,
Jeremy.
More information about the samba-technical
mailing list