[PATCH] notifyd: fix memory alignment

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Jul 16 15:20:24 UTC 2015


On Thu, Jul 16, 2015 at 12:40:59PM +0300, Uri Simchoni wrote:
> Hi,
> 
> Attached pls find a fix to a memory alignment issue in notifyd.
> 
> I'm not familiar enough with the code to tell whether the
> extra-allocation in the fix matters in terms of performance, but at
> least this patch points at the issue.

Your patch will certainly work. Today I can't really look
deeper, but this needs fixing before 4.3.

One quick comment: This is a pretty hot code path, I would
search for ways to do this without malloc (or talloc for
that matter).

Thanks!

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list