[PATCH] winbindd: control number of winbindd's client connections

Jeremy Allison jra at samba.org
Wed Jul 15 18:41:16 UTC 2015


On Mon, Jul 13, 2015 at 10:34:12PM +0300, Uri Simchoni wrote:
> Hi,
> 
> Attached pls find version 6 of this patch set, based on Volker's version:
> - Added bug report - https://bugzilla.samba.org/show_bug.cgi?id=11397
> - Squashed Volker's structural changes
> - Added three patches (7-10) that utilize DLIST_PROMOTE to keep the
> client list sorted and make list scanning O(1)
> - The first patch which self-modifies the FD limit is there for the
> time being - awaiting comments. Indeed, the reason I did it that way
> was that smbd is already doing it.

OK, I've gone through this and I'm happy to add my 'Reviewed-by:'
to this patchset. I think allowing winbindd to set it's own
max fd's is acceptible, as we do this for smbd and it makes
winbindd more self-tuning which makes it easier to deploy
in a 'install-and-forget' scenario, which is what we should
be aiming for in modern software.

Volker, are you also happy ? If so I'll push.

Cheers,

	Jeremy.



More information about the samba-technical mailing list