[PATCH] s3:client: Add "scopy" cmd to perform Server Side copy using smbclient.
Ralph Böhme
rb at sernet.de
Tue Jul 14 08:24:22 UTC 2015
Hi
On Mon, Jul 13, 2015 at 02:47:33PM -0700, Jeremy Allison wrote:
> On Tue, Jul 14, 2015 at 09:39:03AM +1200, Andrew Bartlett wrote:
> >
> > Yes, we need both those tests. This isn't urgent, we should be able to
> > wait till those are written. (I indeed know what your queue looks like,
> > and I really don't want tests forgotten, we must never add untested
> > code).
>
> As it's easier and a lot more fun than doing the bloody review (which
> is extremely complicated code :-), here is a version with both tests added.
> Hope you're happy now :-). Banging out smbclient_s3 tests is always
> fun to do :-).
>
> Ralph, please review and push !
pushed with one minor change:
> + DEBUG(5,("Copied ""%" PRIu64 " bytes at an ", written));
> + DEBUG(5,("average %3.1f kb/s\n",
> + written / (1.024*scopy_total_time_ms)));
DEBUG(5,("Copied %jd bytes at an average %3.1f kb/s\n",
(intmax_t)written, written / (1.024*scopy_total_time_ms)));
-Ralph
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de
More information about the samba-technical
mailing list