[PATCH] s3:client: Add "scopy" cmd to perform Server Side copy using smbclient.

[Andrew Bartlett]

On Fri, 2015-07-10 at 10:34 -0700, Jeremy Allison wrote:
> On Thu, Jun 25, 2015 at 11:37:18AM +0530, Anubhav Rakshit wrote:
> > 
> > 
> > Signed-off-by: Anubhav Rakshit <anubhav.rakshit at gmail.com>
> 
> Thanks Anubhav - this looks really good ! Here is a slightly
> updated version with a few changes.
> 
> 1). Raised the debug level from 1 to 5 of the splice messages
> (doesnt' flood client console).
> 
> 2). Added missing cli_close of src fd if open of dest file fails.
> 
> 3). Added xml-docs for new command.
> 
> Can I get a second Team reviewer ?

We need a blackbox test for this, at the very least.  I also think it
would be better if it was named as 'copy'. 

If practical, to allow tests and to prove the server-side is working it
should have a --force-server-side option that would only work in
server-side.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba